On Fri, 13 Apr 2018 13:36:40 -0300 Hernán Gonzalez <[email protected]> wrote:
> Also remove unnecessary parenthesis I am probably missing something. I'm not sure what you mean by fix bound checking? There are superfluous brackets, but I don't see any functional change to indicate there was anything wrong with the original checks. > > Signed-off-by: Hernán Gonzalez <[email protected]> > --- > drivers/staging/iio/cdc/ad7746.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/iio/cdc/ad7746.c > b/drivers/staging/iio/cdc/ad7746.c > index 516aa93..d793785 100644 > --- a/drivers/staging/iio/cdc/ad7746.c > +++ b/drivers/staging/iio/cdc/ad7746.c > @@ -458,7 +458,7 @@ static int ad7746_write_raw(struct iio_dev *indio_dev, > ret = 0; > break; > case IIO_CHAN_INFO_CALIBBIAS: > - if ((val < 0) | (val > 0xFFFF)) { > + if (val < 0 || val > 0xFFFF) { > ret = -EINVAL; > goto out; > } > @@ -470,7 +470,7 @@ static int ad7746_write_raw(struct iio_dev *indio_dev, > ret = 0; > break; > case IIO_CHAN_INFO_OFFSET: > - if ((val < 0) | (val > 43008000)) { /* 21pF */ > + if (val < 0 || val > 43008000) { /* 21pF */ > ret = -EINVAL; > goto out; > }
