On Tue, Apr 10, 2018 at 11:32:09AM -0700, Jae Hyun Yoo wrote:
> This commit adds dt-bindings documents for PECI cputemp and dimmtemp client
> drivers.
"dt-bindings: hwmon: ..." for the subject.
>
> Signed-off-by: Jae Hyun Yoo <jae.hyun....@linux.intel.com>
> Reviewed-by: Haiyue Wang <haiyue.w...@linux.intel.com>
> Reviewed-by: James Feist <james.fe...@linux.intel.com>
> Reviewed-by: Vernon Mauery <vernon.mau...@linux.intel.com>
> Cc: Alan Cox <a...@linux.intel.com>
> Cc: Andrew Jeffery <and...@aj.id.au>
> Cc: Andrew Lunn <and...@lunn.ch>
> Cc: Andy Shevchenko <andriy.shevche...@intel.com>
> Cc: Arnd Bergmann <a...@arndb.de>
> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org>
> Cc: Fengguang Wu <fengguang...@intel.com>
> Cc: Greg KH <gre...@linuxfoundation.org>
> Cc: Guenter Roeck <li...@roeck-us.net>
> Cc: Jason M Biils <jason.m.bi...@linux.intel.com>
> Cc: Jean Delvare <jdelv...@suse.com>
> Cc: Joel Stanley <j...@jms.id.au>
> Cc: Julia Cartwright <jul...@eso.teric.us>
> Cc: Miguel Ojeda <miguel.ojeda.sando...@gmail.com>
> Cc: Milton Miller II <milt...@us.ibm.com>
> Cc: Pavel Machek <pa...@ucw.cz>
> Cc: Randy Dunlap <rdun...@infradead.org>
> Cc: Stef van Os <stef.van...@prodrive-technologies.com>
> Cc: Sumeet R Pawnikar <sumeet.r.pawni...@intel.com>
> ---
> .../devicetree/bindings/hwmon/peci-cputemp.txt | 24 +++++++++++++++++++++
> .../devicetree/bindings/hwmon/peci-dimmtemp.txt | 25
> ++++++++++++++++++++++
> 2 files changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
> create mode 100644 Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt
>
> diff --git a/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
> b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
> new file mode 100644
> index 000000000000..d5530ef9cfd2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/peci-cputemp.txt
> @@ -0,0 +1,24 @@
> +Bindings for Intel PECI (Platform Environment Control Interface) cputemp
> driver.
> +
> +Required properties:
> +- compatible : Should be "intel,peci-cputemp".
> +- reg : Should contain address of a client CPU. Address range of CPU
> + clients is starting from 0x30 based on PECI specification.
> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition)
Again, where is PECI_OFFSET_MAX defined? It can't depend on something in
the kernel.
> +
> +Example:
> + peci-bus@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + < more properties >
> +
> + peci-cputemp@cpu0 {
> + compatible = "intel,peci-cputemp";
> + reg = <0x30>;
> + };
> +
> + peci-cputemp@cpu1 {
> + compatible = "intel,peci-cputemp";
> + reg = <0x31>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt
> b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt
> new file mode 100644
> index 000000000000..56e5deb61e5c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/peci-dimmtemp.txt
> @@ -0,0 +1,25 @@
> +Bindings for Intel PECI (Platform Environment Control Interface) dimmtemp
> +driver.
> +
> +Required properties:
> +- compatible : Should be "intel,peci-dimmtemp".
> +- reg : Should contain address of a client CPU. Address range of CPU
> + clients is starting from 0x30 based on PECI specification.
> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition)
> +
> +Example:
> + peci-bus@0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + < more properties >
> +
> + peci-dimmtemp@cpu0 {
unit-address is wrong.
It is a different bus from cputemp? Otherwise, you have conflicting
addresses. If that's the case, probably should make it clear by showing
different host adapters for each example.
> + compatible = "intel,peci-dimmtemp";
> + reg = <0x30>;
> + };
> +
> + peci-dimmtemp@cpu1 {
> + compatible = "intel,peci-dimmtemp";
> + reg = <0x31>;
> + };
> + };
> --
> 2.16.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
