2018-04-19 14:09 GMT+02:00 Sekhar Nori <[email protected]>: > On Wednesday 18 April 2018 09:05 PM, Bartosz Golaszewski wrote: >> @@ -373,15 +372,23 @@ static int aemif_probe(struct platform_device *pdev) >> goto error; >> } >> >> - /* >> - * For every controller device node, there is a cs device node that >> - * describe the bus configuration parameters. This functions iterate >> - * over these nodes and update the cs data array. >> - */ >> - for_each_available_child_of_node(np, child_np) { >> - ret = of_aemif_parse_abus_config(pdev, child_np); >> - if (ret < 0) >> - goto error; >> + if (np) { >> + /* >> + * For every controller device node, there is a cs device node >> + * that describe the bus configuration parameters. This >> + * functions iterate over these nodes and update the cs data >> + * array. >> + */ >> + for_each_available_child_of_node(np, child_np) { >> + ret = of_aemif_parse_abus_config(pdev, child_np); >> + if (ret < 0) >> + goto error; >> + } >> + } else if (pdata && pdata->num_abus_data > 0) { >> + for (i = 0; i < pdata->num_abus_data; i++, aemif->num_cs++) { >> + aemif->cs_data[i].cs = pdata->abus_data->cs; > > Since abus_data is an array, shouldn't it be pdata->abus_data[i].cs ? > > Thanks, > Sekhar
Yes, it should. It only worked because we're using a single config entry. Thanks, I'll fix it. Bart
