Hi Baolin,
On Mon, Apr 23, 2018 at 4:08 AM, Baolin Wang <baolin.w...@linaro.org> wrote:
> On 20 April 2018 at 23:22, Arnd Bergmann <a...@arndb.de> wrote:
>> On Thu, Apr 19, 2018 at 8:22 AM, Baolin Wang <baolin.w...@linaro.org> wrote:
>>> The read_persistent_clock() uses a timespec, which is not year 2038 safe
>>> on 32bit systems. Moreover on m68k architecture, we have implemented generic
>>> RTC drivers that can be used to compensate the system suspend time. So
>>> we can remove the obsolete read_persistent_clock().
>>>
>>> Signed-off-by: Baolin Wang <baolin.w...@linaro.org>
>>
>> I'm not sure about this one: it's still possible to turn off
>> CONFIG_RTC_DRV_GENERIC
>> on M68KCLASSIC, and in that case we still need a read_persistent_clock64()
>> implementation. Or we use your patch but make CONFIG_RTC_DRV_GENERIC
>> mandatory.
>
> OK. Thanks for fixing the issue with your patch.
Can I consider that an Acked-by?
Thanks!
>> See below for a version I did a while ago (but never submitted as I got
>> distracted).
>>
>> Arnd
>>
>> commit 13ddf5a33a195e9b7a7a6ed10481363b5259c1d4
>> Author: Arnd Bergmann <a...@arndb.de>
>> Date: Thu Jan 25 15:30:50 2018 +0100
>>
>> m68k: use read_persistent_clock64 consistently
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
