On 24/04/18 11:43, Peter Zijlstra wrote: > On Tue, Apr 24, 2018 at 11:02:26AM +0100, Valentin Schneider wrote: >> I'd argue making things easier to read is a non-negligible part as well. > > Right, so I don't object to either of these (I think); but it would be > good to see this in combination with that proposed EAS change. >
True, I would've said the call to find_energy_efficient_cpu() ([1]) could simply be added to the if (sd) {} case, but... > I think you (valentin) wanted to side-step the entire domain loop in > that case or something. > ...this would change more things. Admittedly I've been sort of out of the loop (no pun intended) lately, but this doesn't ring a bell. That might have been the other frenchie (Quentin) :) > But yes, getting this code more readable is defninitely useful. > [1]: See [RFC PATCH v2 5/6] sched/fair: Select an energy-efficient CPU on task wake-up @ https://lkml.org/lkml/2018/4/6/856