On Tue, Apr 24, 2018 at 10:44 AM, Kirill Marinushkin <k.marinush...@gmail.com> wrote: > In the current implementation, vchi_instance is inited during the first > call of bcm2835_audio_open_connection(), and is never freed. It causes a > memory leak when the module `snd_bcm2835` is removed.
> Signed-off-by: Kirill Marinushkin <k.marinush...@gmail.com> > Cc: Eric Anholt <e...@anholt.net> > Cc: Stefan Wahren <stefan.wah...@i2se.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Florian Fainelli <f.faine...@gmail.com> > Cc: Ray Jui <r...@broadcom.com> > Cc: Scott Branden <sbran...@broadcom.com> > Cc: Andy Shevchenko <andy.shevche...@gmail.com> > Cc: bcm-kernel-feedback-l...@broadcom.com > Cc: linux-rpi-ker...@lists.infradead.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: de...@driverdev.osuosl.org > Cc: linux-kernel@vger.kernel.org AFAIR I gave you a tag and you again missed it. Before sending anything just check twice if all prerequisites are fulfilled. And yes, kbuild bot is right. You need to return known value. -- With Best Regards, Andy Shevchenko
