> -----Original Message----- > From: [email protected] <[email protected]> On > Behalf Of Long Li > Sent: Wednesday, April 25, 2018 2:30 PM > To: Steve French <[email protected]>; [email protected]; samba- > [email protected]; [email protected]; linux- > [email protected] > Cc: Long Li <[email protected]> > Subject: [PATCH v5] cifs: Allocate validate negotiation request through > kmalloc > > From: Long Li <[email protected]> > > The data buffer allocated on the stack can't be DMA'ed, ib_dma_map_page will > return an invalid DMA address for a buffer on stack. Even worse, this > incorrect address can't be detected by ib_dma_mapping_error. Sending data > from this address to hardware will not fail, but the remote peer will get > junk data. > > Fix this by allocating the request on the heap in smb3_validate_negotiate. >
Looks good. Reviewed-By: Tom Talpey <[email protected]>
