Replace the manual validity checks for the GPIO with the
gpio_is_valid().

Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com>
---
 drivers/staging/greybus/arche-platform.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/greybus/arche-platform.c 
b/drivers/staging/greybus/arche-platform.c
index 83254a7..fc6bf60 100644
--- a/drivers/staging/greybus/arche-platform.c
+++ b/drivers/staging/greybus/arche-platform.c
@@ -448,9 +448,9 @@ static int arche_platform_probe(struct platform_device 
*pdev)
        arche_pdata->svc_reset_gpio = of_get_named_gpio(np,
                                                        "svc,reset-gpio",
                                                        0);
-       if (arche_pdata->svc_reset_gpio < 0) {
+       if (!gpio_is_valid(arche_pdata->svc_reset_gpio)) {
                dev_err(dev, "failed to get reset-gpio\n");
-               return arche_pdata->svc_reset_gpio;
+               return -ENODEV;
        }
        ret = devm_gpio_request(dev, arche_pdata->svc_reset_gpio, "svc-reset");
        if (ret) {
@@ -468,9 +468,9 @@ static int arche_platform_probe(struct platform_device 
*pdev)
        arche_pdata->svc_sysboot_gpio = of_get_named_gpio(np,
                                                          "svc,sysboot-gpio",
                                                          0);
-       if (arche_pdata->svc_sysboot_gpio < 0) {
+       if (!gpio_is_valid(arche_pdata->svc_sysboot_gpio)) {
                dev_err(dev, "failed to get sysboot gpio\n");
-               return arche_pdata->svc_sysboot_gpio;
+               return -ENODEV;
        }
        ret = devm_gpio_request(dev, arche_pdata->svc_sysboot_gpio, "sysboot0");
        if (ret) {
@@ -487,9 +487,9 @@ static int arche_platform_probe(struct platform_device 
*pdev)
        arche_pdata->svc_refclk_req = of_get_named_gpio(np,
                                                        "svc,refclk-req-gpio",
                                                        0);
-       if (arche_pdata->svc_refclk_req < 0) {
+       if (!gpio_is_valid(arche_pdata->svc_refclk_req)) {
                dev_err(dev, "failed to get svc clock-req gpio\n");
-               return arche_pdata->svc_refclk_req;
+               return -ENODEV;
        }
        ret = devm_gpio_request(dev, arche_pdata->svc_refclk_req,
                                "svc-clk-req");
-- 
1.9.1

Reply via email to