On Wed, 2 May 2018 09:33:39 +1000
"Tobin C. Harding" <m...@tobin.cc> wrote:
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 031d18b31e0f..3a66507ea60b 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -1725,26 +1725,28 @@ EXPORT_SYMBOL(del_random_ready_callback);
> * key known by the NSA). So it's useful if we need the speed, but
> * only if we're willing to trust the hardware manufacturer not to
> * have put in a back door.
> + *
> + * Return number of bytes filled in.
> */
> -void get_random_bytes_arch(void *buf, int nbytes)
> +int __must_check get_random_bytes_arch(void *buf, int nbytes)
The "__must_check" makes no sense in the C file. It belongs in the
header file. There wont be any complaint about it here.
-- Steve
> {
> char *p = buf;
> diff --git a/include/linux/random.h b/include/linux/random.h
> index 2ddf13b4281e..308168c0a637 100644
> --- a/include/linux/random.h
> +++ b/include/linux/random.h
> @@ -38,7 +38,7 @@ extern void get_random_bytes(void *buf, int nbytes);
> extern int wait_for_random_bytes(void);
> extern int add_random_ready_callback(struct random_ready_callback *rdy);
> extern void del_random_ready_callback(struct random_ready_callback *rdy);
> -extern void get_random_bytes_arch(void *buf, int nbytes);
> +extern int get_random_bytes_arch(void *buf, int nbytes);
>
> #ifndef MODULE
> extern const struct file_operations random_fops, urandom_fops;
