On Fri, Jun 08, 2007 at 02:42:07PM -0700, Andrew Morton wrote: > I'd say just remove the whole thing and use kmem_cache_alloc().
We will try that. > Put much effort into removing the GFP_ATOMIC and using GFP_NOIO instead: > there's your problem right there. As these are called from interrupt handlers, we can't use GFP_NOIO. > If for some reason you really can't do that (and a requirement for > allocation-in-interrupt is the only valid reason, really) and if you indeed > can demonstrate memory allocation failures with certain workloads then > let's take a look at that. As I said, attaching a reserve pool to your > slab cache might be a suitable approach. But none of these things are I agree. We are better off with enhancing slab infrastructure for this, if needed. > magic: if memory allcoation failures or deadlocks or livelocks are > demonstrable with the reserves absent, then they'll also be possible with > the reserves present. > > Unless you use mempools, and can sleep. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
