On 05/04/18 16:51, Peter Rosin wrote: > It gets rid of an #ifdef and the .of_node member is going away. > > Signed-off-by: Peter Rosin <p...@axentia.se> > --- > drivers/gpu/drm/bridge/panel.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index 6d99d4a3beb3..f43d77b5ed20 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -169,10 +169,8 @@ struct drm_bridge *drm_panel_bridge_add(struct drm_panel > *panel, > panel_bridge->connector_type = connector_type; > panel_bridge->panel = panel; > > + panel_bridge->bridge.odev = panel->dev;
I am afraid this approach will eventually conflict with my lately accepted patch[1]. The panel already has a device pointer of its own, and technically the bridge element created here is created by the master drm device itself. I suggest assigning odev here to NULL or to master drm device itself. Best regards, Jyri > panel_bridge->bridge.funcs = &panel_bridge_bridge_funcs; > -#ifdef CONFIG_OF > - panel_bridge->bridge.of_node = panel->dev->of_node; > -#endif > > drm_bridge_add(&panel_bridge->bridge); > > [1] https://lists.freedesktop.org/archives/dri-devel/2018-April/174559.html -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
