On 2018-05-08 09:34 AM, Steven Rostedt wrote:
On Tue, 8 May 2018 09:25:01 -0400
Thomas Tai <thomas....@oracle.com> wrote:

        TP_STRUCT__entry(
                __string(       dev_name,       dev_name        )
                __field(        u32,            status          )
                __field(        u8,             severity        )
+               __field(        u32,            tlp_header_valid)

I'm guessing tlp_header_valid is just a boolean. It's after severity
which is just one byte long. Why not make this one byte as well,
otherwise you are wasting 3 bytes.

Thanks Steven. Yes boolean is fine.

But don't use "bool", use u8, as bool can be various sizes on different
archs.

Sure thing. Thank you.


-- Steve

Reply via email to