Hello, On Tue, May 08, 2018 at 11:46:13AM +0800, Jia-Ju Bai wrote: > The write operation to "host->flags" is protected by > the lock on line 1048, but the read operation to > this data on line 1046 is not protected by the lock. > Thus, there may exist a data race for "host->flags". > > To fix this data race, the read operation to "host->flags" > should be also protected by the lock.
This isn't necessarily wrong. It isn't different from atomic bitops - the modifications are synchronized but what the reads get is determined by memory ordering or other synchronization. Here, the whole suspend / resume paths are always synchronized and the spinlocks are there just in case there are other writers to the field. Thanks. -- tejun
