> -----Original Message-----
> From: ilia...@codeaurora.org <ilia...@codeaurora.org>
> Sent: Thursday, May 17, 2018 10:51
> To: 'Viresh Kumar' <viresh.ku...@linaro.org>; 'Amit Kucheria'
> <amit.kuche...@linaro.org>
> Cc: 'Michael Turquette' <mturque...@baylibre.com>; 'sb...@kernel.org'
> <sb...@kernel.org>; 'Rob Herring' <r...@kernel.org>; 'Mark Rutland'
> <mark.rutl...@arm.com>; 'n...@ti.com' <n...@ti.com>;
> 'lgirdw...@gmail.com' <lgirdw...@gmail.com>; 'broo...@kernel.org'
> <broo...@kernel.org>; 'Andy Gross' <andy.gr...@linaro.org>; 'David Brown'
> <david.br...@linaro.org>; 'catalin.mari...@arm.com'
> <catalin.mari...@arm.com>; 'will.dea...@arm.com'
> <will.dea...@arm.com>; 'Rafael J. Wysocki' <r...@rjwysocki.net>; 'linux-
> c...@vger.kernel.org' <linux-...@vger.kernel.org>;
> 'devicet...@vger.kernel.org' <devicet...@vger.kernel.org>; 'LKML' <linux-
> ker...@vger.kernel.org>; 'Linux PM list' <linux...@vger.kernel.org>;
'linux-
> arm-...@vger.kernel.org' <linux-arm-...@vger.kernel.org>; 'linux-
> s...@vger.kernel.org' <linux-...@vger.kernel.org>; 'lakml' <linux-arm-
> ker...@lists.infradead.org>; 'Rajendra Nayak' <rna...@codeaurora.org>;
> 'nicolas.deche...@linaro.org' <nicolas.deche...@linaro.org>;
> 'cels...@codeaurora.org' <cels...@codeaurora.org>;
> 'tfin...@codeaurora.org' <tfin...@codeaurora.org>
> Subject: RE: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver
>
>
>
> > -----Original Message-----
> > From: Viresh Kumar <viresh.ku...@linaro.org>
> > Sent: Wednesday, May 16, 2018 17:12
> > To: Amit Kucheria <amit.kuche...@linaro.org>
> > Cc: Ilia Lin <ilia...@codeaurora.org>; Michael Turquette
> > <mturque...@baylibre.com>; sb...@kernel.org; Rob Herring
> > <r...@kernel.org>; Mark Rutland <mark.rutl...@arm.com>; n...@ti.com;
> > lgirdw...@gmail.com; broo...@kernel.org; Andy Gross
> > <andy.gr...@linaro.org>; David Brown <david.br...@linaro.org>;
> > catalin.mari...@arm.com; will.dea...@arm.com; Rafael J. Wysocki
> > <r...@rjwysocki.net>; linux-...@vger.kernel.org;
> > devicet...@vger.kernel.org; LKML <linux-kernel@vger.kernel.org>; Linux
> > PM list <linux...@vger.kernel.org>; linux-arm-...@vger.kernel.org;
> > linux- s...@vger.kernel.org; lakml
> > <linux-arm-ker...@lists.infradead.org>;
> > Rajendra Nayak <rna...@codeaurora.org>; nicolas.deche...@linaro.org;
> > cels...@codeaurora.org; tfin...@codeaurora.org
> > Subject: Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver
> >
> > On 16-05-18, 16:12, Amit Kucheria wrote:
> > > > + ret = PTR_ERR_OR_ZERO(opp_temp =
> > > > +
> > dev_pm_opp_set_supported_hw(cpu_dev,&versions,1));
> > > > + if (0 > ret)
> > >
> > > Any particular reason to prefer this over (ret < 0) that is
> > > generally used? I've seen it used to avoid the == vs. = typos, but
> > > not for other comparisons.
> > >
> > > Suggest sticking to what is commonly used i.e. ret < 0.
> > >
> > > > + goto free_opp;
> > > > +
> > > > + cpu_dev = get_cpu_device(GOLD_LEAD);
> > >
> > > Error check cpu_dev here?
> > >
> > > > + ret = PTR_ERR_OR_ZERO(opp_temp =
> > > > +
> > dev_pm_opp_set_supported_hw(cpu_dev,&versions,1));
> > > > + if (0 > ret)
> > > > + goto free_opp;
> >
> > The goto here is wrong
>
> If we are here, then the first dev_pm_opp_set_supported_hw() succeeded.
> And should be deallocated before exit with error.
My bad. Got you.
>
> >
> > > > +
> > > > +
> > > > + ret =
> > PTR_ERR_OR_ZERO(platform_device_register_simple("cpufreq-dt",
> > > > + -1,
> > > > + NULL, 0));
> > > > +
> > > > + if (0 == ret)
> > > > + return 0;
> > > > +
> > > > +free_opp:
> > > > + dev_pm_opp_put_supported_hw(opp_temp);
> > >
> > > This is not needed because dev_pm_opp_set_supported_hw will free
> > > memory in case of failure. This call in only needed in case of a
> > > successful get.
> >
> > But this is still required for the case where platform device
registration fails.
> >
> > --
> > viresh
