On Fri, 18 May 2018 08:26:38 +0200 Ingo Molnar <[email protected]> wrote:
> > * Masami Hiramatsu <[email protected]> wrote: > > > Remove break_handler related code since that was used > > only for jprobe and jprobe is removed now. > > > > Signed-off-by: Masami Hiramatsu <[email protected]> > > --- > > arch/x86/kernel/kprobes/common.h | 10 ---------- > > arch/x86/kernel/kprobes/core.c | 13 ++----------- > > arch/x86/kernel/kprobes/ftrace.c | 16 ++-------------- > > 3 files changed, 4 insertions(+), 35 deletions(-) > > Even after this change there's a stale reference to ->break_handler(): > > arch/x86/include/asm/kprobes.h: * a post_handler or break_handler). > > Please use 'git grep'! Oops, I missed it. Thank you, I'll use git-grep next time. > > Also, there's no reason to send an incomplete series: please remove _all_ > ->break_handler() references so that it's 100% gone! The pain of having and > not > having ->break_handler() is completely unnecessary. Would you mean a single patch for all arch? I'm currently has arch-separated patches for removing it. Should I fold those? Thank you, -- Masami Hiramatsu <[email protected]>
