Borislav Petkov <b...@alien8.de> wrote: > On Fri, May 18, 2018 at 03:46:33PM +0000, Nadav Amit wrote: >> In case you didn’t read the cover-letter: the patch-set does give a 2% >> performance improvement for #PF-MADV_DONTNEED microbenchmark loop. > > I saw it but *micro*-benchmark doesn't tell me a whole lot. If that > "improvement" is not visible in real workloads/benchmarks, then I'm just > as unimpressed.
Funny. I found in my mailbox that you once wrote me: "It is a dumb idea, it doesn't bring us anything besides some superficial readability which you don't really need.” To the point, I think you exaggerate with the effect of the patch on the code readability: it is not much uglier than it was before, and the change is in a very specific point in the code.
