Yisheng Xie <[email protected]> writes: > match_string() returns the index of an array for a matching string, > which can be used intead of open coded variant. > > Cc: Michael Turquette <[email protected]> > Cc: Stephen Boyd <[email protected]> > Cc: Eric Anholt <[email protected]> > Cc: Stefan Wahren <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Yisheng Xie <[email protected]> > --- > drivers/clk/bcm/clk-bcm2835.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index fa0d5c8..a27c0d2 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -1395,8 +1395,7 @@ static struct clk_hw *bcm2835_register_clock(struct > bcm2835_cprman *cprman, > struct bcm2835_clock *clock; > struct clk_init_data init; > const char *parents[1 << CM_SRC_BITS]; > - size_t i, j; > - int ret; > + int i, ret; > > /* > * Replace our strings referencing parent clocks with the > @@ -1405,12 +1404,11 @@ static struct clk_hw *bcm2835_register_clock(struct > bcm2835_cprman *cprman, > for (i = 0; i < data->num_mux_parents; i++) { > parents[i] = data->parents[i]; > > - for (j = 0; j < ARRAY_SIZE(cprman_parent_names); j++) { > - if (strcmp(parents[i], cprman_parent_names[j]) == 0) { > - parents[i] = cprman->real_parent_names[j]; > - break; > - } > - } > + ret = match_string(cprman_parent_names, > + ARRAY_SIZE(cprman_parent_names), > + parents[i]); > + if (ret >= 0) > + parents[i] = cprman->real_parent_names[ret];
Reviewed-by: Eric Anholt <[email protected]>
signature.asc
Description: PGP signature
