On Wed, May 23, 2018 at 8:58 AM Mark Brown <broo...@kernel.org> wrote:
> On Wed, May 23, 2018 at 08:54:18AM -0700, Guenter Roeck wrote: > > On Wed, May 23, 2018 at 6:56 AM Mark Brown <broo...@kernel.org> wrote: > > > On Wed, May 23, 2018 at 03:54:54PM +0200, Takashi Iwai wrote: > > > > And I'm wondering whether we should move these definitions to uapi > > > > headers. > > > Yes, we should. > > Are you sure ? They used to be in > > sound/soc/intel/skylake/skl-tplg-interface.h. > > I took my clue from sound/soc/soc-topology.c, where the v4 structures are > > also > > declared locally and not in the uapi files. > I'm saying we should move them there. They're clearly part of the > userspace ABI and therefore belong in uapi, it was a mistake to let them > be elsewhere. They define a firmware file format. Not sure if I would call that userspace ABI. I don't mind adding the structures to sound/soc/intel/skylake/skl-tplg-interface.h, but it seems a bit out of scope to tie this with moving the file to include/uapi/sound. I think that should be a separate discussion. Thanks, Guenter
