On Thu, Jun 14, 2007 at 01:39:18PM +0530, vignesh babu wrote:
>
>
> Replacing (n & (n-1)) in the context of power of 2 checks
> with is_power_of_2
>
> Signed-off-by: vignesh babu <[EMAIL PROTECTED]>
Acked-by: Evgeniy Dushistov <[EMAIL PROTECTED]>
> ---
> diff --git a/fs/ufs/super.c b/fs/ufs/super.c
> index 22ff6ed..2b30116 100644
> --- a/fs/ufs/super.c
> +++ b/fs/ufs/super.c
> @@ -87,6 +87,7 @@
> #include <linux/smp_lock.h>
> #include <linux/buffer_head.h>
> #include <linux/vfs.h>
> +#include <linux/log2.h>
>
> #include "swab.h"
> #include "util.h"
> @@ -854,7 +855,7 @@ magic_found:
> uspi->s_fmask = fs32_to_cpu(sb, usb1->fs_fmask);
> uspi->s_fshift = fs32_to_cpu(sb, usb1->fs_fshift);
>
> - if (uspi->s_fsize & (uspi->s_fsize - 1)) {
> + if (!is_power_of_2(uspi->s_fsize)) {
> printk(KERN_ERR "ufs_read_super: fragment size %u is not a
> power of 2\n",
> uspi->s_fsize);
> goto failed;
> @@ -869,7 +870,7 @@ magic_found:
> uspi->s_fsize);
> goto failed;
> }
> - if (uspi->s_bsize & (uspi->s_bsize - 1)) {
> + if (!is_power_of_2(uspi->s_bsize)) {
> printk(KERN_ERR "ufs_read_super: block size %u is not a power
> of 2\n",
> uspi->s_bsize);
> goto failed;
>
> --
> Vignesh Babu BM
> _____________________________________________________________
> "Why is it that every time I'm with you, makes me believe in magic?"
>
>
>
> The information contained in this electronic message and any attachments to
> this message are intended for the exclusive use of the addressee(s) and may
> contain proprietary, confidential or privileged information. If you are not
> the intended recipient, you should not disseminate, distribute or copy this
> e-mail. Please notify the sender immediately and destroy all copies of this
> message and any attachments.
>
> WARNING: Computer viruses can be transmitted via email. The recipient should
> check this email and any attachments for the presence of viruses. The company
> accepts no liability for any damage caused by any virus transmitted by this
> email.
>
> www.wipro.com
--
/Evgeniy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
