On 05/28/2018 02:47 AM, Maciej Purski wrote: > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > index fa2c799..58e19af 100644 > --- a/drivers/gpu/drm/bridge/Kconfig > +++ b/drivers/gpu/drm/bridge/Kconfig > @@ -110,6 +110,13 @@ config DRM_THINE_THC63LVD1024 > ---help--- > Thine THC63LVD1024 LVDS/parallel converter driver. > > +config DRM_TOSHIBA_TC358764 > + tristate "TC358764 DSI/LVDS bridge" > + depends on DRM && DRM_PANEL > + depends on OF > + select DRM_MIPI_DSI > + select VIDEOMODE_HELPERS > +
Kconfig symbols with "prompt strings" should also have help text. I expected checkpatch to catch that, but I tested it and there was no warning from checkpatch about help text. OTOH, there was a warning that there are 2 lines in this patch that end with whitespace, so that should be fixed. Did you use checkpatch (scripts/checkpatch.pl)? > config DRM_TOSHIBA_TC358767 > tristate "Toshiba TC358767 eDP bridge" > depends on OF thanks, -- ~Randy
