Let's return early when lock_task_sighand() fails and move send_signal()
and unlock_task_sighand() out of the if block.

Signed-off-by: Christian Brauner <christ...@brauner.io>
---
v0->v1:
* patch unchanged
---
 kernel/signal.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index baae137455eb..a628b56415e6 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1167,16 +1167,16 @@ specific_send_sig_info(int sig, struct siginfo *info, 
struct task_struct *t)
 }
 
 int do_send_sig_info(int sig, struct siginfo *info, struct task_struct *p,
-                       bool group)
+                    bool group)
 {
        unsigned long flags;
        int ret = -ESRCH;
 
-       if (lock_task_sighand(p, &flags)) {
-               ret = send_signal(sig, info, p, group);
-               unlock_task_sighand(p, &flags);
-       }
+       if (!lock_task_sighand(p, &flags))
+               return ret;
 
+       ret = send_signal(sig, info, p, group);
+       unlock_task_sighand(p, &flags);
        return ret;
 }
 
-- 
2.17.0

Reply via email to