On 05/24/2018 06:28 AM, Juri Lelli wrote: > On 17/05/18 16:55, Waiman Long wrote: > > [...] > >> @@ -849,7 +860,12 @@ static void rebuild_sched_domains_locked(void) >> * passing doms with offlined cpu to partition_sched_domains(). >> * Anyways, hotplug work item will rebuild sched domains. >> */ >> - if (!cpumask_equal(top_cpuset.effective_cpus, cpu_active_mask)) >> + if (!top_cpuset.isolation_count && >> + !cpumask_equal(top_cpuset.effective_cpus, cpu_active_mask)) >> + goto out; >> + >> + if (top_cpuset.isolation_count && >> + !cpumask_subset(top_cpuset.effective_cpus, cpu_active_mask)) >> goto out; > Do we cover the case in which hotplug removed one of the isolated cpus > from cpu_active_mask?
Yes, you are right. That is the remnant of my original patch that allows only one isolated_cpus at root. Thanks for spotting that. Cheers, Longman
