On 6/1/2018 11:06 AM, Alex G. wrote:
> On 06/01/2018 10:03 AM, Sinan Kaya wrote:
>> On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote:
>>> +   /* Multi-function PCIe share the same link/status. */
>>> +   if (PCI_FUNC(dev->devfn) != 0)
>>> +           return;
>>
>> How about virtual functions?
> 
> I have almost no clue about those. Is your concern that we might end up
> printing more than our fair share of link statuses?

Yes, struct pci_dev also has a flag called is_virtfn that you should bail out
here too. 

> 
> Alex
> 
> 


-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux 
Foundation Collaborative Project.

Reply via email to