Hi Pavel, >>> Describe which hardware is supported by the current driver. >>> >>> Cc: Marcel Holtmann <[email protected]> >>> Cc: Johan Hedberg <[email protected]> >>> Cc: Rob Herring <[email protected]> >>> Cc: Johan Hovold <[email protected]> >>> Cc: [email protected] >>> Signed-off-by: Ricardo Ribalda Delgado <[email protected]> >>> --- >>> drivers/bluetooth/hci_nokia.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c >>> index 3539fd03f47e..e32dfcd56b8d 100644 >>> --- a/drivers/bluetooth/hci_nokia.c >>> +++ b/drivers/bluetooth/hci_nokia.c >>> @@ -801,6 +801,11 @@ static const struct of_device_id >>> nokia_bluetooth_of_match[] = { >>> MODULE_DEVICE_TABLE(of, nokia_bluetooth_of_match); >>> #endif >>> >>> +static struct serdev_device_id nokia_bluetooth_serdev_id[] = { >>> + { "hp4-bluetooth", }, >>> + {}, >>> +}; >>> + >>> static struct serdev_device_driver nokia_bluetooth_serdev_driver = { >>> .probe = nokia_bluetooth_serdev_probe, >>> .remove = nokia_bluetooth_serdev_remove, >>> @@ -809,6 +814,7 @@ static struct serdev_device_driver >>> nokia_bluetooth_serdev_driver = { >>> .pm = &nokia_bluetooth_pm_ops, >>> .of_match_table = of_match_ptr(nokia_bluetooth_of_match), >>> }, >>> + .id_table = nokia_bluetooth_serdev_id, >>> }; >> >> I would actually skip this hardware. First of all it is such a dedicated >> custom Nokia transport and hardware, and secondly it is no longer produced >> anyway. >> > > Would it make sense to cc: sre here? We want good support even for old > hardware, and this is n9/n950, it is still on "top ten supported > phones" list... Probably even top 5.
but that is not what this patch series is about. We do not need new_id kinda support for the existing hardware. My point is there will be no newly designed hardware using this driver. Regards Marcel
