Hi, On 07/06/2018 14:00:16+0300, Radu Pirea wrote: > diff --git a/include/dt-bindings/mfd/at91-usart.h > b/include/dt-bindings/mfd/at91-usart.h > new file mode 100644 > index 000000000000..ac811628a42d > --- /dev/null > +++ b/include/dt-bindings/mfd/at91-usart.h > @@ -0,0 +1,17 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * This header provides macros for AT91 USART DT bindings. > + * > + * Copyright (C) 2018 Microchip Technology > + * > + * Author: Radu Pirea <radu.pi...@microchip.com> > + * > + */ > + > +#ifndef __DT_BINDINGS_AT91_USART_H__ > +#define __DT_BINDINGS_AT91_USART_H__ > + > +#define AT91_USART_MODE_SERIAL 1 > +#define AT91_USART_MODE_SPI 2 > +
Nitpick, I'd make that 0 and 1 instead of 1 and 2. That would feel more natural to me regarding the default value. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
