On Sun, Jun 10, 2018 at 02:59:23PM +0100, Jonathan Cameron wrote: > On Thu, 7 Jun 2018 16:11:05 +0300 > Stefan Popa <stefan.p...@analog.com> wrote: > > > Signed-off-by: Stefan Popa <stefan.p...@analog.com> > Hmm. The first part number I've ever googled where the top hit has > been a flight number. > Rio de Janeiro to Campinas is apparently on time today. > > > --- > > Changes in v2: > > - Nothing changed, just to follow the patch set version. > > > > .../devicetree/bindings/iio/dac/ad5758.txt | 84 > > ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 85 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/ad5758.txt > > b/Documentation/devicetree/bindings/iio/dac/ad5758.txt > > new file mode 100644 > > index 0000000..75fff6c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/dac/ad5758.txt > > @@ -0,0 +1,84 @@ > > +Analog Devices AD5758 DAC device driver > > + > > +Required properties for the AD5758: > > + - compatible: Must be "adi,ad5758" > > + - reg: SPI chip select number for the device > > + - spi-max-frequency: Max SPI frequency to use (< 50000000) > > + - spi-cpha: is the only mode that is supported > > + > > +Optional properties: > > + > > + - adi,dc-dc-mode: Mode of operation of the dc-to-dc converter > > + The following values are currently supported: > > + * 0: DC-to-DC converter powered off > > + * 1: DPC current mode > Perhaps expand those acronyms? > Dynamic Power Control and perhaps a bit of explanation so people > who are ready DT files don't have to go find the data sheet to have > some idea of what these are? > > Otherwise, binding is fine. > > > + * 2: DPC voltage mode > > + * 3: PPC current mode > > + > > + - adi,dc-dc-ilim: The dc-to-dc converter current limit > > + The following values are currently supported [mA]: > Unit should be in the name. > adi,dc-dc-ilim_ma
Yes, but don't use '_' and follow what is in property-units.txt.
