On Mon, 2018-05-28 at 12:02 +0200, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Guenter Roeck <[email protected]> > > [ Upstream commit 415eb2a1aaa4881cf85bd86c683356fdd8094a23 ] > > pwmX_mode is defined in the ABI as 0=DC mode, 1=pwm mode. The chip > register bit is set to 1 for DC mode. This got mixed up, and writing > 1 into pwmX_mode resulted in DC mode enabled. Fix it up by using > the ABI definition throughout the driver for consistency. > > Fixes: 77eb5b3703d99 ("hwmon: (nct6775) Add support for pwm, pwm_mode, ... ") > Signed-off-by: Guenter Roeck <[email protected]> > Signed-off-by: Sasha Levin <[email protected]> > Signed-off-by: Greg Kroah-Hartman <[email protected]> [...]
The code changes look fine but the comment on the declaration of nct6775_data::pwm_mode is now incorrect. Ben. -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom
