On 06/29/2018 01:29 PM, Randy Dunlap wrote: > On 06/29/2018 12:28 PM, Mike Rapoport wrote: >> Hi Randy, >> >> On Fri, Jun 29, 2018 at 09:34:55AM -0700, Randy Dunlap wrote: >>> On 06/29/2018 06:42 AM, Mike Rapoport wrote: >>>> Otherwise mm configuration options show up in the top level menu. >>>> >>>> Signed-off-by: Mike Rapoport <r...@linux.vnet.ibm.com> >>> Hi Mike, >>> >>> In which config tool does this matter? >>> >>> For xconfig, it seems to me that this patch hides the MM menu, whereas >>> before this patch, the MM menu is easy to find (although it could >>> use some kind of heading). >> With xconfig the menu gets into the top right pane when you click on "ARC >> architecture configuration", similar to what one gets on x86 with >> "Processor type and features" or "Kernel features" on ARM. >> >> With menuconfig it looks a bit more prominent, note that mm options are >> between "ARC Architecture Configuration" and "Networking support": > I know. I ran all 4 of menuconfig, nconfig, xconfig, and gconfig. > > I would prefer to see Memory Management options have its own top-level > menu, but that's a different patch. Then menuconfig would look like this: > > > > │ │ *** Compiler: arc-linux-gcc (GCC) 8.1.0 *** │ │ > │ │ General setup ---> │ │ > > │ │ [*] Enable loadable module support ---> │ │ > > │ │ [*] Enable the block layer ---> │ │ > > │ │ ARC Architecture Configuration ---> │ │ > > │ │ Memory Management options ---> │ │ > > │ │ (11) Maximum zone order │ │ > > │ │ [*] Networking support ---> │ │ > > │ │ Device Drivers ---> │ │ > > │ │ Bus Support --->
Indeed I realized after applying that we are cluttering the mm stuff inside ARC. So I don't see real net improvement with this patch/ > but that "Maximum zone order" needs to be moved or taken care of somehow. Right this is mm specific option which is provided for by arch. And even a redirector like ARCH_HAS_FORCE_MAX and moving this to generic mm won't cut it since the option values are arch specific ! -Vineet
