Anson Huang
Best Regards!


> -----Original Message-----
> From: Fabio Estevam [mailto:[email protected]]
> Sent: Monday, July 2, 2018 7:33 AM
> To: Shawn Guo <[email protected]>; Anson Huang
> <[email protected]>
> Cc: Robin Gong <[email protected]>; Mark Rutland
> <[email protected]>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <[email protected]>; linux-kernel
> <[email protected]>; Rob Herring <[email protected]>;
> dl-linux-imx <[email protected]>; Sascha Hauer <[email protected]>;
> Fabio Estevam <[email protected]>; moderated list:ARM/FREESCALE
> IMX / MXC ARM ARCHITECTURE <[email protected]>
> Subject: Re: [PATCH v1] ARM: dts: imx6sl-evk: keep sw4 always on
> 
> On Sun, Jul 1, 2018 at 6:34 AM, Shawn Guo <[email protected]> wrote:
> > On Mon, Jun 25, 2018 at 08:34:11PM +0800, Robin Gong wrote:
> >> SW4 is one power rail for LPDDR2 on i.mx6sl-evk, so it should be kept
> >> always on. But it's disabled after switch disabled interface
> >> implemented in pfuze driver 'commit 5fe156f1cab4
> >> ("regulator: pfuze100: add enable/disable for switch")'.Thus, it
> >> breaks kernel bootup. Add 'regulator-always-on' for SW4.
> >>
> >> Signed-off-by: Robin Gong <[email protected]>
> >
> > Does that mean boards with existing DTB installed will stop working
> > with new kernel?  That's bad, and the kernel commit should probably be
> > reverted.
> 
> Yes, this is a good point.
> 
> Anson,
> 
> Should 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for
> switch") be reverted to avoid such breakage?
 
Yes, I think we can revert it to avoid breakage. Didn't notice that some
i.MX platform do NOT have those critical switches always-on.

Anson.

Reply via email to