2018-07-02 2:12 GMT+09:00 Randy Dunlap <[email protected]>: > From: Randy Dunlap <[email protected]> > > Verify that 'depmod' ($DEPMOD) is installed. > This is a partial revert of 620c231c7a7f (from 2012): > ("kbuild: do not check for ancient modutils tools") > > Fixes kernel bugzilla #198965: > https://bugzilla.kernel.org/show_bug.cgi?id=198965 > > Signed-off-by: Randy Dunlap <[email protected]> > Cc: Lucas De Marchi <[email protected]> > Cc: Michal Marek <[email protected]> > Cc: Chih-Wei Huang <[email protected]> > Cc: [email protected] # any kernel since 2012 > --- > scripts/depmod.sh | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > --- lnx-418-rc2.orig/scripts/depmod.sh > +++ lnx-418-rc2/scripts/depmod.sh > @@ -10,10 +10,16 @@ fi > DEPMOD=$1 > KERNELRELEASE=$2 > > -if ! test -r System.map -a -x "$DEPMOD"; then > +if ! test -r System.map ; then > exit 0 > fi > > +if [ -z $(command -v $DEPMOD) ]; then > + echo "'make *install' requires $DEPMOD. Please install it." >&2
I think depmod is required by 'make modules_install' Is there any reason to make this ambiguous like 'make *install' ? > + echo "This is probably in the module-init-tools package." >&2 > + exit 1 > +fi > + > # older versions of depmod require the version string to start with three > # numbers, so we cheat with a symlink here > depmod_hack_needed=true > > -- Best Regards Masahiro Yamada
