Hi, Fabio Anson Huang Best Regards!
> -----Original Message----- > From: Fabio Estevam [mailto:[email protected]] > Sent: Sunday, July 15, 2018 12:13 AM > To: Anson Huang <[email protected]> > Cc: Linus Walleij <[email protected]>; open list:GPIO SUBSYSTEM > <[email protected]>; linux-kernel <[email protected]>; > dl-linux-imx <[email protected]> > Subject: Re: [PATCH] gpio: mxc: add power management support > > Hi Anson, > > On Fri, Jul 13, 2018 at 10:53 PM, Anson Huang <[email protected]> > wrote: > > > Here are the details, i.MX7D LPSR mode and i.MX8QM/8QXP etc.' > > suspend/resume may cause GPIO bank lose power, so need to > > save/restore, for other i.MX SoCs, although no need to do > > save/restore, but doing it is NOT harmful, so do you think we should add SoC > type check here? > > I think it would be safer to restrict the save/restore operations to mx7/mx8. > > You can add a fsl,imx7d-gpio compatible entry in the driver. > > Thanks OK, since i.MX7D has same GPIO type as i.MX35, to make it simple, I just added a flag to indicate whether it supports save/restore, only i.MX7D enables the flag now, since other i.MX8 SoCs' dts is NOT upstreamed yet, so I did NOT add support for i.MX8 SoCs, please help review V2 patch, thanks. Anson.
