On Sun, 2018-07-22 at 00:39 +0530, dev-harsh1998 wrote: > WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using > octal permissions '0444'. > +static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); [] > diff --git a/drivers/input/touchscreen/ad7877.c > b/drivers/input/touchscreen/ad7877.c [] > @@ -461,7 +461,7 @@ name ## _show(struct device *dev, struct device_attribute > *attr, char *buf) \ > return v; \ > return sprintf(buf, "%u\n", (unsigned) v); \ > } \ > -static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); > +static DEVICE_ATTR(name, 0444, name ## _show, NULL);
I believe this could be static DEVICE_ATTR_RO(name)
