Re: [PATCH 34/38] vfs: syscall: Add fsinfo() to query filesystem information [ver #10]

[Jann Horn]

On Sat, Jul 28, 2018 at 1:51 AM David Howells <dhowe...@redhat.com> wrote:
> David Howells <dhowe...@redhat.com> wrote:
>
> > One thing I'm confused about is that fat has both a codepage and a charset 
> > and
> > I'm not sure of the difference.
>
> In fact, it's not clear that the codepage is actually used.
>
>         warthog>git grep '[.>]codepage'
>         fs/fat/inode.c: opts->codepage = fat_default_codepage;
>         fs/fat/inode.c:                 opts->codepage = option;
>         fs/fat/inode.c: sprintf(buf, "cp%d", sbi->options.codepage);

        sprintf(buf, "cp%d", sbi->options.codepage);
        sbi->nls_disk = load_nls(buf);
        if (!sbi->nls_disk) {
                fat_msg(sb, KERN_ERR, "codepage %s not found", buf);
                goto out_fail;
        }