Hi Laura,
On Mon, Jul 30, 2018 at 07:47:52AM -0700, Laura Abbott wrote:
> On 07/30/2018 12:33 AM, Stephen Rothwell wrote:
> >On Fri, 27 Jul 2018 13:55:22 +0100 Will Deacon <will.dea...@arm.com> wrote:
> >>On Fri, Jul 27, 2018 at 08:55:11PM +1000, Stephen Rothwell wrote:
> >>>Actually, it may have been caused by commit
> >>>
> >>> 0b3e336601b8 ("arm64: Add support for STACKLEAK gcc plugin")
> >>>
> >>>from the arm64 tree.
> >>
> >>Thanks, Stephen. I managed to reproduce this by merging for-next/kspp from
> >>Kees's tree and for-next/core from the arm64 tree. The failure happens when
> >>building the EFI stub, so the commit you mention above is almost certainly
> >>the culprit.
> >>
> >>We build the stub with the following GCC invocation:
> >>
> >> gcc -Wp,-MD,drivers/firmware/efi/libstub/.efi-stub-helper.o.d -nostdinc
> >> -isystem /usr/lib/gcc/x86_64-linux-gnu/4.9/include -I./arch/x86/include
> >> -I./arch/x86/include/generated -I./include -I./arch/x86/include/uapi
> >> -I./arch/x86/include/generated/uapi -I./include/uapi
> >> -I./include/generated/uapi -include ./include/linux/kconfig.h -include
> >> ./include/linux/compiler_types.h -D__KERNEL__ -mcmodel=small -m64
> >> -D__KERNEL__ -O2 -fPIC -fno-strict-aliasing -mno-red-zone -mno-mmx
> >> -mno-sse -fshort-wchar -DDISABLE_BRANCH_PROFILING -D__NO_FORTIFY
> >> -ffreestanding -fno-stack-protector -fplugin-arg-stackleak_plugin-disable
> >> -fno-builtin -DKBUILD_BASENAME='"efi_stub_helper"'
> >> -DKBUILD_MODNAME='"efi_stub_helper"' -c -o
> >> drivers/firmware/efi/libstub/.tmp_efi-stub-helper.o
> >> drivers/firmware/efi/libstub/efi-stub-helper.c
> >>
> >>so given that we're not passing any -fplugin= option anyway (because we
> >>override KBUILD_CFLAGS for the stub), I don't understand why we need
> >>to the disable option at all.
> >>
> >>Laura?
> >
> >So today I am just trying reverting that arm64 tree commit.
> >
>
> It looks like arm and arm64 start from the KBUILD_CFLAGS and
> then filter out vs. x86 which just specifies the CFLAGS individually,
> hence x86 picking up the disable when there's no plugin at all. This
> seems to be the simplest fix unless we want to change arm64 to not
> pick up all the KBUILD_CFLAGS to match x86. That seems like a more
> involved process though. If this is okay, I can send a patch
> that also sticks a comment in there explaining why fixing on arm64
> is necessary.
Indeed, I posted a very similar patch last week!
https://lore.kernel.org/lkml/CAGXu5jJ=0YBYKkQM3=kzrp1o3ft0ygy6-0udkkit0wenfm3...@mail.gmail.com/T/#m1bd3d2de78e33da4d1f496fd82be7cf088ebaa06
If you send a version with a commit message, I'm happy to pick it up.
Cheers,
Will
