On Thu, 2018-08-02 at 23:30 +0200, Linus Walleij wrote: > On Wed, Aug 1, 2018 at 1:12 PM Florian Eckert <f...@dev.tdt.de> wrote: [] > > + spinlock_t lock; > > I think checkpatch now mandates that you put in a comment > about what this lock is locking.
Please remember that checkpatch doesn't mandate anything. Documentation/process/4.Coding.rst does have: Certain things should always be commented. Uses of memory barriers should be accompanied by a line explaining why the barrier is necessary. The locking rules for data structures generally need to be explained somewhere. So there should be some comment somewhere in the code for the spinlock.
