Hi Dan,

Thank you for the patch.

Typo in the patch title:

s/di: /dt-/

And maybe let's change the following text to:

"Add bindings for lm3697 LED driver"

Best regards,
Jacek Anaszewski

On 08/03/2018 05:02 PM, Dan Murphy wrote:
> Introduce the device tree bindings for the lm3697
> led driver for backlighting and display.
> 
> Signed-off-by: Dan Murphy <dmur...@ti.com>
> ---
>  .../devicetree/bindings/leds/leds-lm3697.txt  | 64 +++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt 
> b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
> new file mode 100644
> index 000000000000..7b8e490f1ea1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
> @@ -0,0 +1,64 @@
> +* Texas Instruments - LM3697 Highly Efficient White LED Driver
> +
> +The LM3697 11-bit LED driver provides high-
> +performance backlight dimming for 1, 2, or 3 series
> +LED strings while delivering up to 90% efficiency.
> +
> +This device is suitable for Display and Keypad Lighting
> +
> +Required properties:
> +     - compatible:
> +             "ti,lm3967"
> +     - reg :  I2C slave address
> +     - #address-cells : 1
> +     - #size-cells : 0
> +     - control-bank-cfg - : Indicates which sink is connected to which 
> control bank
> +             0 - All HVLED outputs are controlled by bank A
> +             1 - HVLED1 is controlled bank B, HVLED2/3 are controlled by 
> bank A
> +             2 - HVLED2 is controlled bank B, HVLED1/3 are controlled by 
> bank A
> +             3 - HVLED1/2 are controlled by bank B, HVLED3 is controlled by 
> bank A
> +             4 - HVLED3 is controlled by bank B, HVLED1/2 are controlled by 
> bank A
> +             5 - HVLED1/3 is controlled by bank B, HVLED2 is controlled by 
> bank A
> +             6 - (default) HVLED1 is controlled by bank A, HVLED2/3 are 
> controlled by bank B
> +             7 - All HVLED outputs are controlled by bank B
> +
> +Optional properties:
> +     - enable-gpios : gpio pin to enable/disable the device.
> +     - vled-supply : LED supply
> +
> +Required child properties:
> +     - reg : 0 - LED is Controlled by bank A
> +             1 - LED is Controlled by bank B
> +
> +Optional child properties:
> +     - label : see Documentation/devicetree/bindings/leds/common.txt
> +     - linux,default-trigger :
> +        see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example:
> +
> +led-controller@36 {
> +     compatible = "ti,lm3967";
> +     reg = <0x36>;
> +     #address-cells = <1>;
> +     #size-cells = <0>;
> +
> +     enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> +     vled-supply = <&vbatt>;
> +     control-bank-cfg = <0>;
> +
> +     led@0 {
> +             reg = <0>;
> +             label = "white:first_backlight_cluster";
> +             linux,default-trigger = "backlight";
> +     };
> +
> +     led@1 {
> +             reg = <1>;
> +             label = "white:second_backlight_cluster";
> +             linux,default-trigger = "frontlight";
> +     };
> +}
> +
> +For more product information please see the link below:
> +http://www.ti.com/lit/ds/symlink/lm3697.pdf
> 

Reply via email to