On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > Now that the /firmware/coreboot node in DT is populated by the core DT > platform code with commit 3aa0582fdb82 ("of: platform: populate > /firmware/ node from of_platform_default_populate_init()") we should and
Does this deserve a 'Fixes' tag? Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()") The coreboot-of driver was in 4.12, and it seems to have broken in 4.16, along with the above patch. > can remove the platform device creation here. Otherwise, the > of_platform_device_create() call will fail, the coreboot of driver won't > be registered, and this driver will never bind. At the same time, we can > move this driver to use platform device APIs instead of DT specific ones > and drop the of_node handling that was presumably placed there to hold a > reference to the DT node created during module init. > > Cc: Wei-Ning Huang <wnhu...@chromium.org> > Cc: Julius Werner <jwer...@chromium.org> > Cc: Brian Norris <briannor...@chromium.org> Reviewed-by: Brian Norris <briannor...@chromium.org> > Cc: Samuel Holland <sam...@sholland.org> > Cc: Thierry Escande <thierry.esca...@collabora.com> > Signed-off-by: Stephen Boyd <swb...@chromium.org> > --- > drivers/firmware/google/coreboot_table-of.c | 39 +++++---------------- > 1 file changed, 9 insertions(+), 30 deletions(-)