On Tue, Aug 07, 2018 at 11:00:50PM -0700, Stephen Boyd wrote: > Quoting Brian Norris (2018-08-07 14:41:04) > > On Mon, Aug 06, 2018 at 10:10:47AM -0700, Stephen Boyd wrote: > > > @@ -44,8 +43,9 @@ static int coreboot_table_of_remove(struct > > > platform_device *pdev) > > > > > > static const struct of_device_id coreboot_of_match[] = { > > > { .compatible = "coreboot" }, > > > - {}, > > > + {} > > > > ...and since I had a *real* comment, I'll mention this bit I noticed > > previously...this diff seems a bit superfluous. I understand we don't > > really want to extend this list beyond the NULL terminator, but > > normally, I'd expect we leave it alone. > > > > I was adding MODULE_DEVICE_TABLE nearby. I'll leave the removal here > unless you really hate the style cleanup.
My ugly and imprecise grepping tells me you're going to have a fun time enforcing your sense of style, but good luck ;) $ git grep -n -A 10 'of_device_id.*\[\] = ' | grep '{\s*}$' | wc -l 1020 $ git grep -n -A 10 'of_device_id.*\[\] = ' | grep '{\s*},$' | wc -l 1348