On Sun, Aug 5, 2018 at 1:33 PM tip-bot for Nick Desaulniers <[email protected]> wrote: > > Commit-ID: 208cbb32558907f68b3b2a081ca2337ac3744794 > Gitweb: > https://git.kernel.org/tip/208cbb32558907f68b3b2a081ca2337ac3744794 > Author: Nick Desaulniers <[email protected]> > AuthorDate: Fri, 3 Aug 2018 10:05:50 -0700 > Committer: Thomas Gleixner <[email protected]> > CommitDate: Sun, 5 Aug 2018 22:30:37 +0200 > > x86/irqflags: Provide a declaration for native_save_fl > > It was reported that the commit d0a8d9378d16 is causing users of gcc < 4.9 > to observe -Werror=missing-prototypes errors. > > Indeed, it seems that: > extern inline unsigned long native_save_fl(void) { return 0; } > > compiled with -Werror=missing-prototypes produces this warning in gcc < > 4.9, but not gcc >= 4.9. > > Fixes: d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline"). > Reported-by: David Laight <[email protected]> > Reported-by: Jean Delvare <[email protected]> > Signed-off-by: Nick Desaulniers <[email protected]> > Signed-off-by: Thomas Gleixner <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > Cc: [email protected]
Not sure if this was going to be cleaned up in an automated way, but looks like this commit message drops the comment to stable as to how far back it should go: # 4.17, 4.14, 4.9, 4.4 also, there were tested by's reported: Tested-by: David Laight <[email protected]> Tested-by: Sedat Dilek <[email protected]> -- Thanks, ~Nick Desaulniers
