On Thu, Aug 09, 2018 at 01:23:58PM +0200, Lars-Peter Clausen wrote: > On 08/09/2018 11:30 AM, Mark Brown wrote:
> It is. But it might make sense to re-order the code to look like > > case 54000000: > if (source != ADAV80X_PLL_SRC_XIN) > return -EINVAL; > > pll_ctrl1 |= ADAV80X_PLL_CTRL1_PLLDIV; > break; > It is just as many lines added when adding the /* fall through */, but it > makes it more obvious what is going on. Yes, it's much more obvious.
signature.asc
Description: PGP signature
