On Mon,  6 Aug 2018 22:14:12 -0700, Douglas Anderson <diand...@chromium.org> 
wrote:
> After the commit 8b1087fa3a27 ("phy: qcom-qmp: Fix dts bindings to
> reflect reality") landed there was some review feedback that 'reg'
> should have been documented differently.  Fix it as per review
> feedback.
> 
> As per that feedback:
> - Subject should have been 'dt-bindings: phy:' which this patch now
>   has.
> - We should leave no ambiguity in the ordering of 'reg' ranges even if
>   'reg-names' are also specified.
> - Normally using reg-names is discouraged unless there's a strong
>   reason it's needed (like if there are optional ranges).  In this
>   case reg-names wasn't needed but the driver already landed relying
>   on reg-names so we'll just document it and move on.
> 
> Fixes: 8b1087fa3a27 ("phy: qcom-qmp: Fix dts bindings to reflect reality")
> Suggested-by: Rob Herring <r...@kernel.org>
> Signed-off-by: Douglas Anderson <diand...@chromium.org>
> ---
> 
>  .../devicetree/bindings/phy/qcom-qmp-phy.txt  | 19 +++++++++++--------
>  1 file changed, 11 insertions(+), 8 deletions(-)
> 

Reviewed-by: Rob Herring <r...@kernel.org>

Reply via email to