> -----Original Message----- > From: Jarkko Sakkinen [mailto:[email protected]] > Sent: Tuesday, August 28, 2018 7:17 PM > To: Huang, Kai <[email protected]> > Cc: [email protected]; [email protected]; Hansen, Dave > <[email protected]>; Christopherson, Sean J > <[email protected]>; [email protected]; > [email protected]; [email protected]; Kai Huang > <[email protected]>; Thomas Gleixner <[email protected]>; Ingo > Molnar <[email protected]>; H. Peter Anvin <[email protected]>; Borislav > Petkov <[email protected]>; Konrad Rzeszutek Wilk <[email protected]>; > David Woodhouse <[email protected]>; open list:X86 ARCHITECTURE (32- > BIT AND 64-BIT) <[email protected]> > Subject: Re: [PATCH v13 02/13] x86/cpufeature: Add SGX and SGX_LC CPU > features > > On Tue, Aug 28, 2018 at 12:07:41AM +0000, Huang, Kai wrote: > > > +#define X86_FEATURE_SGX_LC (16*32+30) /* supports SGX > launch > > > configuration */ > > > > Sorry if it was me who wrote the comment "SGX launch configuration". I > > think we should just use "SGX launch control". :) > > Not sure if we should change though. The former is more self-explaining, the > latter is "more official".
I'll let you decide. To me the comment should explain what does "LC" mean, and to me it means "launch control". :) Thanks, -Kai > > /Jarkko

