Hi Miguel, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.19-rc1 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Miguel-Ojeda/Compiler-Attributes-remove-unused-attributes/20180901-125644 config: i386-tinyconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 Note: the linux-review/Miguel-Ojeda/Compiler-Attributes-remove-unused-attributes/20180901-125644 HEAD 4327b9ceea1b6be41cbce2c51370a365fc6a52cc builds fine. It only hurts bisectibility. All error/warnings (new ones prefixed by >>): In file included from include/uapi/linux/swab.h:7:0, from include/linux/swab.h:5, from include/uapi/linux/byteorder/little_endian.h:13, from include/linux/byteorder/little_endian.h:5, from arch/x86/include/uapi/asm/byteorder.h:5, from include/asm-generic/bitops/le.h:6, from arch/x86/include/asm/bitops.h:521, from include/linux/bitops.h:19, from include/linux/kernel.h:11, from include/asm-generic/bug.h:18, from arch/x86/include/asm/bug.h:83, from include/linux/bug.h:5, from include/linux/page-flags.h:10, from kernel/bounds.c:10: >> arch/x86/include/uapi/asm/swab.h:8:15: error: unknown type name >> '__attribute_const__' static inline __attribute_const__ __u32 __arch_swab32(__u32 val) ^~~~~~~~~~~~~~~~~~~ >> arch/x86/include/uapi/asm/swab.h:8:41: error: expected '=', ',', ';', 'asm' >> or '__attribute__' before '__arch_swab32' static inline __attribute_const__ __u32 __arch_swab32(__u32 val) ^~~~~~~~~~~~~ arch/x86/include/uapi/asm/swab.h:15:15: error: unknown type name '__attribute_const__' static inline __attribute_const__ __u64 __arch_swab64(__u64 val) ^~~~~~~~~~~~~~~~~~~ >> arch/x86/include/uapi/asm/swab.h:15:41: error: expected '=', ',', ';', 'asm' >> or '__attribute__' before '__arch_swab64' static inline __attribute_const__ __u64 __arch_swab64(__u64 val) ^~~~~~~~~~~~~ In file included from include/linux/swab.h:5:0, from include/uapi/linux/byteorder/little_endian.h:13, from include/linux/byteorder/little_endian.h:5, from arch/x86/include/uapi/asm/byteorder.h:5, from include/asm-generic/bitops/le.h:6, from arch/x86/include/asm/bitops.h:521, from include/linux/bitops.h:19, from include/linux/kernel.h:11, from include/asm-generic/bug.h:18, from arch/x86/include/asm/bug.h:83, from include/linux/bug.h:5, from include/linux/page-flags.h:10, from kernel/bounds.c:10: >> include/uapi/linux/swab.h:47:15: error: unknown type name >> '__attribute_const__' static inline __attribute_const__ __u16 __fswab16(__u16 val) ^~~~~~~~~~~~~~~~~~~ >> include/uapi/linux/swab.h:47:41: error: expected '=', ',', ';', 'asm' or >> '__attribute__' before '__fswab16' static inline __attribute_const__ __u16 __fswab16(__u16 val) ^~~~~~~~~ include/uapi/linux/swab.h:56:15: error: unknown type name '__attribute_const__' static inline __attribute_const__ __u32 __fswab32(__u32 val) ^~~~~~~~~~~~~~~~~~~ >> include/uapi/linux/swab.h:56:41: error: expected '=', ',', ';', 'asm' or >> '__attribute__' before '__fswab32' static inline __attribute_const__ __u32 __fswab32(__u32 val) ^~~~~~~~~ include/uapi/linux/swab.h:65:15: error: unknown type name '__attribute_const__' static inline __attribute_const__ __u64 __fswab64(__u64 val) ^~~~~~~~~~~~~~~~~~~ >> include/uapi/linux/swab.h:65:41: error: expected '=', ',', ';', 'asm' or >> '__attribute__' before '__fswab64' static inline __attribute_const__ __u64 __fswab64(__u64 val) ^~~~~~~~~ include/uapi/linux/swab.h:78:15: error: unknown type name '__attribute_const__' static inline __attribute_const__ __u32 __fswahw32(__u32 val) ^~~~~~~~~~~~~~~~~~~ >> include/uapi/linux/swab.h:78:41: error: expected '=', ',', ';', 'asm' or >> '__attribute__' before '__fswahw32' static inline __attribute_const__ __u32 __fswahw32(__u32 val) ^~~~~~~~~~ include/uapi/linux/swab.h:87:15: error: unknown type name '__attribute_const__' static inline __attribute_const__ __u32 __fswahb32(__u32 val) ^~~~~~~~~~~~~~~~~~~ >> include/uapi/linux/swab.h:87:41: error: expected '=', ',', ';', 'asm' or >> '__attribute__' before '__fswahb32' static inline __attribute_const__ __u32 __fswahb32(__u32 val) ^~~~~~~~~~ include/uapi/linux/swab.h: In function '__swahw32p': >> include/uapi/linux/swab.h:144:2: error: implicit declaration of function >> '__fswahw32'; did you mean '__swahw32'? >> [-Werror=implicit-function-declaration] __fswahw32(x)) ^ >> include/uapi/linux/swab.h:207:9: note: in expansion of macro '__swahw32' return __swahw32(*p); ^~~~~~~~~ include/uapi/linux/swab.h: In function '__swahb32p': >> include/uapi/linux/swab.h:155:2: error: implicit declaration of function >> '__fswahb32'; did you mean '__swahb32'? >> [-Werror=implicit-function-declaration] __fswahb32(x)) ^ >> include/uapi/linux/swab.h:222:9: note: in expansion of macro '__swahb32' return __swahb32(*p); ^~~~~~~~~ In file included from include/linux/kernel.h:12:0, from include/asm-generic/bug.h:18, from arch/x86/include/asm/bug.h:83, from include/linux/bug.h:5, from include/linux/page-flags.h:10, from kernel/bounds.c:10: include/linux/log2.h: At top level: >> include/linux/log2.h:202:1: error: expected '=', ',', ';', 'asm' or >> '__attribute__' before 'int' int __order_base_2(unsigned long n) ^~~ cc1: some warnings being treated as errors make[2]: *** [kernel/bounds.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [sub-make] Error 2 vim +/__attribute_const__ +8 arch/x86/include/uapi/asm/swab.h 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 7 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 @8 static inline __attribute_const__ __u32 __arch_swab32(__u32 val) 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 9 { e5bb8ad8 arch/x86/include/asm/swab.h H. Peter Anvin 2012-11-28 10 asm("bswapl %0" : "=r" (val) : "0" (val)); 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 11 return val; 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 12 } 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 13 #define __arch_swab32 __arch_swab32 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 14 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 @15 static inline __attribute_const__ __u64 __arch_swab64(__u64 val) 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 16 { 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 17 #ifdef __i386__ 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 18 union { 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 19 struct { 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 20 __u32 a; 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 21 __u32 b; 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 22 } s; 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 23 __u64 u; 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 24 } v; 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 25 v.u = val; 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 26 asm("bswapl %0 ; bswapl %1 ; xchgl %0,%1" 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 27 : "=r" (v.s.a), "=r" (v.s.b) 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 28 : "0" (v.s.a), "1" (v.s.b)); 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 29 return v.u; 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 30 #else /* __i386__ */ e5bb8ad8 arch/x86/include/asm/swab.h H. Peter Anvin 2012-11-28 31 asm("bswapq %0" : "=r" (val) : "0" (val)); 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 32 return val; 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 33 #endif 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 34 } 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 35 #define __arch_swab64 __arch_swab64 5d30a683 arch/x86/include/asm/swab.h Harvey Harrison 2009-01-06 36 :::::: The code at line 8 was first introduced by commit :::::: 5d30a683888c60b8f93bef3ddc139d1a91ca58f4 x86: introduce asm/swab.h :::::: TO: Harvey Harrison <harvey.harri...@gmail.com> :::::: CC: Linus Torvalds <torva...@linux-foundation.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
