On Sat, Sep 01, 2018 at 03:38:13PM +0200, Miguel Ojeda wrote: > Hi Nick, > > On Sat, Sep 1, 2018 at 1:07 AM, Nick Desaulniers > <ndesaulni...@google.com> wrote: > > Overall, pretty happy with this patch. Still some thoughts for a v3, > >> -#define __visible __attribute__((externally_visible)) > >> diff --git a/include/linux/compiler_attributes.h > >> b/include/linux/compiler_attributes.h > >> new file mode 100644 > >> index 000000000000..a9dfafc8fd19 > >> --- /dev/null > >> +++ b/include/linux/compiler_attributes.h > >> @@ -0,0 +1,226 @@ > > > > New file needs an SPDX license identifier right? > > Yeah, but I wasn't sure of adding it, since the code I moved (even if > rearranged) from _types.h does not have it either. Any legal expert > here? Is _types.h it implicitly GPL 2? We should add the identifier to > both if so.
It looks like we missed that file in the big "properly add SPDX identifiers to all files without a license" commit as it came in from a different tree. But yes, it is GPLv2 only implicitly, so you can add that. I should sweep the tree again to see if anything else has been added accidentally with that same problem. thanks, greg k-h
