On Thu 2018-09-06 15:59:04, Jerome Brunet wrote: > When probing, if we fail to get the pwm due to probe deferal, we shouldn't > print an error message. Just be silent in this case. > > Signed-off-by: Jerome Brunet <[email protected]> > --- > drivers/leds/leds-pwm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c > index df80c89ebe7f..5d3faae51d59 100644 > --- a/drivers/leds/leds-pwm.c > +++ b/drivers/leds/leds-pwm.c > @@ -100,8 +100,9 @@ static int led_pwm_add(struct device *dev, struct > led_pwm_priv *priv, > led_data->pwm = devm_pwm_get(dev, led->name); > if (IS_ERR(led_data->pwm)) { > ret = PTR_ERR(led_data->pwm); > - dev_err(dev, "unable to request PWM for %s: %d\n", > - led->name, ret); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "unable to request PWM for %s: %d\n", > + led->name, ret); > return ret; > }
Hmm, sometimes probing is deffered forever, and in such case debug
message is useful.
Do you see excessive number of these?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
signature.asc
Description: Digital signature
