On Thursday 06 Sep 2018 at 16:49:47 (-0700), Dietmar Eggemann wrote: > I would prefer a sched_feature. I guess it has to be disabled by default so > that other systems don't have to check rcu_dereference(rd->pd) in the wakeup > path.
Right, this is what I had in mind too. I guess downstream kernels can always carry a patch that changes the default if they want it enabled without messing around in userspace. > But since at the beginning EAS will be the only user of the EM there is no > need to change the static key sched_energy_present right now. Indeed, I could add a patch introducing this sched_feat in the series that migrates IPA to using the EM framework (to be posted later). It is just not required until we have a new user. However that IPA-related patchset would then change the default behaviour for users who used to get EAS enabled automatically, but wouldn't after updating their kernel (meaning they'd now have to flip switches by hand whereas it used to "just work"). Not sure if that qualifies as "breaking users" (cf. Linus' rule #1 of kernel development) ... Thanks, Quentin