Reported-by: Jan Lorenzen <[email protected]> On Thu, Sep 13, 2018 at 3:37 PM Ricardo Ribalda Delgado <[email protected]> wrote: > > The current code only frees N-1 gpios if an error occurs during > gpiod_set_transitory, gpiod_direction_output or gpiod_direction_input. > Leading to gpios that cannot be used by userspace nor other drivers. > > Cc: Timur Tabi <[email protected]> > Cc: [email protected] > Fixes: ab3dbcf78f60f46d ("gpioib: do not free unrequested descriptors) > Signed-off-by: Ricardo Ribalda Delgado <[email protected]> > --- > drivers/gpio/gpiolib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index e8f8a1999393..a57300c1d649 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -571,7 +571,7 @@ static int linehandle_create(struct gpio_device *gdev, > void __user *ip) > if (ret) > goto out_free_descs; > lh->descs[i] = desc; > - count = i; > + count = i + 1; > > if (lflags & GPIOHANDLE_REQUEST_ACTIVE_LOW) > set_bit(FLAG_ACTIVE_LOW, &desc->flags); > -- > 2.18.0 >
-- Ricardo Ribalda
