On Sat, Sep 15, 2018 at 12:13:22AM +0530, Himanshu Jha wrote: > Hi Song, > > On Thu, Sep 13, 2018 at 10:22:29AM +0800, Song Qiang wrote: > > This driver was originally written by ST in 2016 as a misc input device > > driver, and hasn't been maintained for a long time. I grabbed some code > > from it's API and reformed it into a iio proximity device driver. > > This version of driver uses i2c bus to talk to the sensor and > > polling for measuring completes, so no irq line is needed. > > This version of driver supports only one-shot mode, and it can be > > tested with reading from > > /sys/bus/iio/devices/iio:deviceX/in_distance_raw > > > > Signed-off-by: Song Qiang <songqiang.1304...@gmail.com> > > I'm sorry but you probably need another revision. > > And don't feel embarrassed, I mean this is your first patch > in the kernel and that's an IIO driver!! > > I used to fix spelling mistakes, align parameters, ... an year ago > and even those got rejected several times ;) > > > --- > > > +ST VL53L0X ToF RANGER(I2C) IIO DRIVER > > +M: Song Qiang <songqiang.1304...@gmail.com> > > +L: linux-...@vger.kernel.org > > +S: Maintained > > +F: drivers/iio/proximity/vl53l0x-i2c.c > > +F: Documentation/devicetree/bindings/iio/proximity/vl53l0x.txt > > Obligations! > > Just don't go "Keyser Söze" once you're done with your major > at University. You would need to test/review patches in future. > > Not a big deal though.. > > > + > > +static const struct of_device_id st_vl53l0x_dt_match[] = { > > + { .compatible = "st,vl53l0x-i2c", }, > > + { } > > +}; > > MODULE_DEVICE_TABLE(of, st_vl53l0x_dt_match); ? > > > Thanks > -- > Himanshu Jha > Undergraduate Student > Department of Electronics & Communication > Guru Tegh Bahadur Institute of Technology
Hi Himanshu, I think I'll do some double check on it to make sure it's good, compare my patch with other drivers to see some more problems I miss. Thanks for your kindness, and with or without this patch accepted, I've been feeling glad to get connected with the community and learned a lot from people like you. :) yours, Song Qiang