Hi Boris, Thanks a lot for the review.
> -----Original Message----- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, September 18, 2018 1:23 PM > To: Manish Narani <mnar...@xilinx.com> > Cc: robh...@kernel.org; mark.rutl...@arm.com; mche...@kernel.org; > Michal Simek <mich...@xilinx.com>; leoyang...@nxp.com; > sudeep.ho...@arm.com; amit.kuche...@linaro.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > e...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v7 1/7] edac: synopsys: Fix code comments and naming > convention > > On Mon, Sep 17, 2018 at 07:54:59PM +0530, Manish Narani wrote: > > Update the comments in the Synopsys EDAC driver. Minor changes to > > function names and return types are also included. > > > > Signed-off-by: Manish Narani <manish.nar...@xilinx.com> > > --- > > drivers/edac/synopsys_edac.c | 176 > > ++++++++++++++++++++----------------------- > > 1 file changed, 80 insertions(+), 96 deletions(-) > > So this patch does a bunch of things together and should be split into: > > * functional changes like code cleanup > * functions renaming > * comments cleanup > > Maybe in that order. > > This way you'll have one logical set of changes per patch and review will be > almost trivial. > Okay, I will do that in v8. Thanks, Manish
