On 09/28/2018 10:37 AM, Ravi Bangoria wrote:
> Hi Thomas,
>
> On 09/28/2018 01:13 PM, Thomas Richter wrote:
>> diff --git a/tools/perf/tests/builtin-test.c
>> b/tools/perf/tests/builtin-test.c
>> index 54ca7d87236f..e83c15a95c43 100644
>> --- a/tools/perf/tests/builtin-test.c
>> +++ b/tools/perf/tests/builtin-test.c
>> @@ -124,7 +124,7 @@ static struct test generic_tests[] = {
>> .desc = "Watchpoint",
>> .func = test__wp,
>> .subtest = {
>> - .skip_if_fail = false,
>> + .skip_if_fail = true,
>
> Can you instead use ".is_supported"?
>
> Thanks,
> Ravi
>
Hi Ravi,
I can rework the patch to use the is_supported() member function. The
down side is that the test does not show up in the list of executed tests
anymore,
unless some debug output is enabled:
[root@s8360046 perf]# ./perf test -F 22
[root@s8360046 perf]# ./perf test -Fv 22
22: Watchpoint : Disabled
[root@s8360046 perf]#
I leave it to Arnaldo to decide...
--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB
243294
